Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webauthn support #176

Open
sbrl opened this issue Oct 7, 2019 · 2 comments
Open

Webauthn support #176

sbrl opened this issue Oct 7, 2019 · 2 comments
Labels
enhancement Let's make it better!

Comments

@sbrl
Copy link
Owner

sbrl commented Oct 7, 2019

Now that I've got a hardware security key, it would be really cool if Pepperminty Wiki supported passwordless login with Webauthn. We'll have to get our crypto hat on though, because it's sure to be a bit of a challenge to work with.

Thankfully, @My1 on Twitter has provided some sample code for us to analyse as a starting point: https://gist.github.com/My1/7ab5c4b154164331ac2ef18a65fd8a64

@sbrl sbrl added the enhancement Let's make it better! label Oct 7, 2019
@My1
Copy link

My1 commented Oct 7, 2019

to be honest it is kinda dirty and meant to be as easy as possible for me (no object classes outside the one(s) from the library and unneeded functions, just a "pull the trigger and go" thing

also since it was for a sandbox implementation that isnt meant to be abused I do not have any exception checking yet and so on just a VERY basic limitation on the userid and check on the credentialid to stop the most obvious sql injection ideas

@sbrl
Copy link
Owner Author

sbrl commented Oct 8, 2019

Thanks for the info, @My1!

Indeed, as part of the analysis and implementation I'll look at extensively improving and refactoring it, so get it to fit with Pepperminty Wiki's programming style - and to handle all the edge cases.

I'm quite busy at the moment though, so it may have to wait a while 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Let's make it better!
Projects
None yet
Development

No branches or pull requests

2 participants