Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using a media URL from a private user that my user follows #305

Open
1 task done
DrewKiino opened this issue Nov 8, 2022 · 1 comment
Open
1 task done
Assignees
Labels
critical A critical issue or urgent pull request

Comments

@DrewKiino
Copy link

  • I've searched past issues and I couldn't find reference to this.

Swiftagram version
e.g. 5.4.0, etc.

Describe the bug
Pasting a followed private user's post causes a crash

To reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
sdk does not crash.

Additional context
go to Instagram in the app, go to a user that you know is private but is visible to you because you follow them. go to one of their posts and copy the post url. use .media(url) and see crash.

Screen Shot 2022-11-07 at 10 00 28 PM

Device and system
e.g. macOS 10.5.16, iPhone Simulator 13.5.

@DrewKiino DrewKiino added the critical A critical issue or urgent pull request label Nov 8, 2022
@sbertix
Copy link
Owner

sbertix commented Dec 5, 2022

Hey @DrewKiino,

Sorry for the late reply.
I was originally made aware of this in #294, which I unfortunately closed before actually removing the code from 5.* cause, at the time, I was planning on releasing 6.0.0 soon.
That code was basically scrapped, though, and I'm rewriting it as we speak, so I'll keep this open, for reference.
Like I mentioned in the other issue, this won't be fixed. It's outside the scopes of the actual Instagram Private API (it's not an endpoint) and it's something I had added for convenience when all permalink were built like that. As it's no longer the case the method will be simply removed.

@sbertix sbertix changed the title crash when using a media URL from a private user that my user follows Crash when using a media URL from a private user that my user follows Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical A critical issue or urgent pull request
Projects
None yet
Development

No branches or pull requests

2 participants