Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing xplr with q or closing the terminal window closes any files opened in gui #689

Open
Anomalocaridid opened this issue Jan 13, 2024 · 3 comments

Comments

@Anomalocaridid
Copy link

Anomalocaridid commented Jan 13, 2024

When I open files with gx, the programs they are open in are closed when I either close xplr's terminal window or close xplr with q, but not when I close it with enter.

I expected it to not close the programs regardless of how I close xplr.

  • OS version: NixOS unstable
  • xplr version: 0.21.3
  • window manager: Hyprland, built from commit 880996b05339ba87066958a517885f1941185269
  • terminal: wezterm 20230712-072601-f4abf8fd
@sayanarijit
Copy link
Owner

I couldn't reproduce in my NixOS with KDE (xorg). Maybe Hyperland issue?

@sayanarijit
Copy link
Owner

NixOS + KDE Wayland also works fine.

@Anomalocaridid
Copy link
Author

Anomalocaridid commented Jan 13, 2024

After taking another look at it, I realized I should have mentioned how I was opening xplr because that appears to have an effect. Sorry about that.

I have a Hyprland keybind that opens it using the following command (which behaves the same if I just run the command manually):
wezterm start -- xplr

It also appears to do the same thing if I have wezterm run it through a shell rather than directly:
wezterm start -- fish -c 'xplr'

The same thing happens if I replace fish with another shell like bash.

xplr does, in fact, behave as expected if I manually run the command in a terminal shell instead.

It also works as expected if I modify the above command to use -C instead of -c so that fish loads my config before running xplr, but then that does not have the benefit of closing the terminal window when I am done with xplr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants