Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of aria-labels #263

Open
rogierv88 opened this issue Feb 13, 2024 · 2 comments
Open

Incorrect use of aria-labels #263

rogierv88 opened this issue Feb 13, 2024 · 2 comments

Comments

@rogierv88
Copy link

Some elements have aria-labels that can not have these labels. Aria labels should only be applied on interactive elements or HTML landmarks.
As far as I could find this applies to the 404 h1 element and the disabled version of the LinkButton element.

@benjaminrae
Copy link
Contributor

As far as I can see this use of aria-label is valid according to https://w3c.github.io/aria/#aria-label

However as it says title may be preferred but would create a tooltip, or even aria-labelled-by.

@rogierv88
Copy link
Author

As stated on https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label, the aria-label should only be used on interactive elements or HTML landmarks. Which is not the case for an h1 or span element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants