Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning with `%||% reexport from rlang #177

Closed
lionel- opened this issue Jan 9, 2024 · 2 comments · Fixed by #178
Closed

Warning with `%||% reexport from rlang #177

lionel- opened this issue Jan 9, 2024 · 2 comments · Fixed by #178

Comments

@lionel-
Copy link

lionel- commented Jan 9, 2024

I'm seeing this report in CRAN checks:

Package: scCustomize
Check: whether package can be installed
New result: WARNING
  Found the following significant warnings:
    Warning: replacing previous import ‘Seurat::%||%’ by ‘rlang::%||%’ when loading ‘scCustomize’

Currently rlang::%||% is copied into the SeuratObject namespace:

`%||%` <- rlang::`%||%`

This should be a reexport instead, like you did in Seurat with

#' @importFrom SeuratObject %||%
#' @rdname reexports
#' @export
#'
SeuratObject::`%||%`

Hopefully that will be enough to fix the warning in scCustomize. If not, you might need to reexport %||% from Seurat directly from rlang instead of SeuratObject.

@mojaveazure mojaveazure linked a pull request Jan 9, 2024 that will close this issue
@mojaveazure
Copy link
Member

Hi Lionel,

Thanks for reporting. We did it this way to control how %||% shows up in documentation (roxygen2 is rather aggressive about how it documents reexports). We'll adjust this to properly reexport rather than redefine %||%

@lionel-
Copy link
Author

lionel- commented Jan 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants