Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing new lines in expanded output #2179

Closed
bertusgroenewegen opened this issue Sep 13, 2016 · 6 comments
Closed

Missing new lines in expanded output #2179

bertusgroenewegen opened this issue Sep 13, 2016 · 6 comments

Comments

@bertusgroenewegen
Copy link

bertusgroenewegen commented Sep 13, 2016

Missing new lines in expanded output.

 @mixin sprite-arrow() {
    @extend %hidden-text;
 }

  %hidden-text {
    text-indent: -999em;
 }

// button.scss
.button-left,
.button-right,
.button-plus,
.button-min {
    &:after {
        @include sprite-arrow();
    }
}

.banner {
    &:after {
        @include sprite-arrow();
    }
}

.calculator {
    .btn-down,
    .btn-up {
        &:after {
            @include sprite-arrow();
        }
    }
}

LibSass 3.3.7

.button-left:after,
.button-min:after,
.button-plus:after,
.button-right:after, .banner:after, .calculator .btn-down:after,
.calculator .btn-up:after {
  text-indent: -999em;
}

Ruby Sass

.button-left:after,
.button-min:after,
.button-plus:after,
.button-right:after, 
.banner:after,
.calculator .btn-down:after,
.calculator .btn-up:after {
  text-indent: -999em;
}
@xzyfer xzyfer changed the title unexpected expanded output with mixin in combination with extend Missing new lines in expanded output Sep 13, 2016
@xzyfer
Copy link
Contributor

xzyfer commented Sep 13, 2016

@bertusgroenewegen thanks for the report. I've updated issue with working example and accurate title.

@bertusgroenewegen
Copy link
Author

@xzyfer I would appreciate it, if you could fix this minor bug :) pretty please

@xzyfer
Copy link
Contributor

xzyfer commented Dec 22, 2016

@bertusgroenewegen there are no immediate plans to fix this. Output style bugs are our lowest priority because they don't change the behaviour of the output.

@bertusgroenewegen
Copy link
Author

but they boost the score CSS on Sonarqube :) I know its minor minor and you're already investing alot of your time. I can buy you a big coffee donation 10 euro in return :)

@automagisch
Copy link

automagisch commented Jun 19, 2017

+1 on this issue! You get a big coffee from me as well if this fix happens :) For now I'm trying to create a workaround with Node, if that is a success I'll try to link this here as well.

@mgreter
Copy link
Contributor

mgreter commented Mar 12, 2018

Closing since ruby sass 3.5.6 output is the same:

.button-left:after,
.button-right:after,
.button-plus:after,
.button-min:after, .banner:after, .calculator .btn-down:after,
.calculator .btn-up:after {
  text-indent: -999em; }

@mgreter mgreter closed this as completed Mar 12, 2018
xzyfer pushed a commit to mgreter/sass-spec that referenced this issue Mar 23, 2018
xzyfer pushed a commit to sass/sass-spec that referenced this issue Mar 23, 2018
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Mar 23, 2018
xzyfer added a commit to sass/sass-spec that referenced this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants