Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception handler during _create_subprocess failures doesn't intersperse strings properly #49

Closed
techalchemy opened this issue Dec 9, 2018 · 0 comments · Fixed by #50
Closed

exception handler during _create_subprocess failures doesn't intersperse strings properly #49

techalchemy opened this issue Dec 9, 2018 · 0 comments · Fixed by #50
Assignees
@techalchemy

Comments

@techalchemy
Copy link
Member

ref: pypa/pipenv#3363
@techalchemy techalchemy self-assigned this Dec 9, 2018
techalchemy added a commit that referenced this issue Dec 9, 2018
@techalchemy
Provide a way to capture or wrap streams
46c23cd 
- Also fix a bug with error reporting during `_create_subprocess`
  failures
- Adds a stream wrapper using `TextIOWrapper` via
  `vistir.misc.StreamWrapper`
- Adds `vistir.misc.get_wrapped_stream()` function to wrap existing
  streams
- Adds `vistir.contextmanagers.replaced_stream()` to temporarily replace
  a stream
- Fixes #49
- Closes #48

Signed-off-by: Dan Ryan <dan@danryan.co>
@techalchemy techalchemy mentioned this issue Dec 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide a way to capture or wrap streams sarugaku/vistir
1 participant
@techalchemy