Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures #58

Closed
brainwane opened this issue Mar 4, 2020 · 2 comments · Fixed by #57
Closed

Fix test failures #58

brainwane opened this issue Mar 4, 2020 · 2 comments · Fixed by #57
Assignees
@techalchemy
Labels
bug Something isn't working in progress
Milestone
Release pip-shims...

Comments

@brainwane
Copy link

@techalchemy what are the specific current test failures that need fixing?
@brainwane brainwane added bug Something isn't working in progress labels Mar 4, 2020
@brainwane brainwane added this to the Release pip-shims 0.20.1 milestone Mar 4, 2020
@brainwane
Copy link
Author

(Resolving this will also help with pypa/pipenv#4058 (comment) and pypa/pipenv#3369 , since pip-shims problems are blocking the pipenv release.)

@brainwane brainwane mentioned this issue Mar 4, 2020
Open
@techalchemy techalchemy mentioned this issue Mar 4, 2020
Closed
30 tasks
@techalchemy
Copy link
Member

InstallRequirement.ensure_build_location now takes an additional argument on pip@master -- autodelete:

TypeError: ensure_build_location() missing 1 required positional argument: 'autodelete'

WheelCache instances are now built from temporary directories which require a global_tempdir_manager context (so will require a shim on pip >= 20)

techalchemy added a commit that referenced this issue Mar 5, 2020
@techalchemy
Fix test failures against pip@master
7a77147 
- Add `wheel_cache` context manager helper for managing global context
  when creating wheel wheel_cache instances
- Add optional `check_supports_wheel` argument to `Resolver.resolve()`
  call when expected arguments include this one
- Inspect `InstallRequirement.ensure_build_location()` method and
  include `autodelete` kwarg if it is expected
- Update argument types passed into `resolver.resolve` which, as of
  `pip>=20.1` will expect a list of `InstallRequirement` instances
- Update `Resolver` import path to point at new location
  (`resolution.legacy.resolver`)
- Add necessary `global_tempdir_manager` contexts in tests
- Fix expected `RequirementSet.cleanup()` call after
  `Resolver.resolve()` which no longer applies due to use of transient
  `RequirementSet`
- Fixes #58
- Fixes #59
- Fixes #60
- Fixes #61
- Fixes #62

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
@techalchemy techalchemy mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techalchemy techalchemy

Labels
bug Something isn't working in progress
Projects
None yet
Milestone
Release pip-shims 0.20.1
Development

Successfully merging a pull request may close this issue.

Fix compat.get_session sarugaku/pip-shims
2 participants
@brainwane @techalchemy