Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for flutter web? #58

Closed
MilesAdamson opened this issue Aug 25, 2019 · 12 comments
Closed

Support for flutter web? #58

MilesAdamson opened this issue Aug 25, 2019 · 12 comments
Assignees
Labels
enhancement New feature or request WIP Work In Progress

Comments

@MilesAdamson
Copy link

Hi. Your package looks great but I can't get it to work on flutter web. Do you think this is currently possible, or planned for the future?

@Skquark
Copy link

Skquark commented Oct 8, 2019

Same question/request here.. Trying hard to keep my app web compatible because it looks so great in a browser, right? Hasn't been easy. The YouTube player is one of the primary capabilities I needed too.. I know there's a lot of io dependancies out of our control that currently breaks, but wondering if there's a chance to workaround to eventually get this working on web?

@sarbagyastha
Copy link
Owner

I'll look into it.

@sarbagyastha sarbagyastha added enhancement New feature or request WIP Work In Progress labels Oct 23, 2019
@sarbagyastha sarbagyastha self-assigned this Nov 2, 2019
@dheerajsarwaiya
Copy link

looking forward for web support

@itsMatoosh
Copy link

Any news on this?

@d-apps
Copy link

d-apps commented Apr 26, 2020

Any news?

@sarbagyastha
Copy link
Owner

At the time this PR was raised. Iframes would rebuilt infinitly in web. Haven't tried in web for a while, will test if the issue still persists soon.

@BrutalCoding
Copy link

At the time this PR was raised. Iframes would rebuilt infinitly in web. Haven't tried in web for a while, will test if the issue still persists soon.

Hi,

I've had that before too, not sure since when it - changed but my iFrames do not rebuild infinitly anymore (e.g. when scrolling). Running on Flutter beta channel (1.18-0-11.1.pre) today.

However I hope you can find a solution so that the iFrames are not capturing all input from the user anymore. As of now, if I got YouTube video's (iFrames) next to each other exceeding the screen, you would usually scroll (horizontally) but since the iFrames are stealing the input, Flutter doesn't know that. Which means scrolling doesn't work.

@sarbagyastha
Copy link
Owner

@BrutalCoding Thanks for the info. Will look into it.

@sarbagyastha
Copy link
Owner

sarbagyastha commented Jun 1, 2020

Related Issue flutter/#56477 flutter/#55430

@BrutalCoding
Copy link

BrutalCoding commented Jun 11, 2020

Related Issue flutter/#56477 flutter/#55430

These issues are not happening on my end, you can check out some YouTube video's here PurrGames (flutter web).

Most of the games contain YouTube videos on the bottom of their page. Now I'm not sure anymore if I did have the issue and fixed it, or that it's simply not an issue anymore with Flutter for web.

Let me know if you want to know more, or work together to get your plugin compatible with Web.

edit 26/6/2020:
I've updated the web app by limiting the video's to a maximum of 3 that fit on the screen, this prevents users that are trying to scroll to the next video(s) because that was impossible. To see the scrolling issue, hover your mouse over one of the videos and try to scroll back up the page, it won't work.

Also, again, no issues with re-rendering/flickering during scrolling on the page.

edit 28/2/2023 (few years later):

  • fix: Add prefix "https://" to the PurrGames URL mentioned above. Otherwise GitHub wouldn't launch it (anymore?).
  • funfact: The demo website I set up (PurrGames) is still running on the same Flutter version and code as when I made this comment. Pretty cool I'd say!

@sarbagyastha
Copy link
Owner

Added web support through https://pub.dev/packages/youtube_player_iframe .
Will soon migrate the current plugin too.

@paketeserrano
Copy link

Thanks for the work on this flutter plugin. I am using youtube_player_flutter and I realized that it's not working on web. I saw that you fixed it for the youtube_player_iframe, do you have plans to move it to youtube_player_flutter? Not sure if there is a separate ticket for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work In Progress
Projects
None yet
Development

No branches or pull requests

8 participants