Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could this model be called a real GAN? The discriminator might contribute nothing to the performance. #71

Open
ANYMS-A opened this issue Aug 15, 2019 · 1 comment

Comments

@ANYMS-A
Copy link

ANYMS-A commented Aug 15, 2019

Hi there, recently I'm trying to reproduce this SEGAN model and find out some questions.

The biggest question is about the loss function of the discriminator. As we know the original GAN's discriminator is doing binary classification task. So it use a Sigmoid at the last output layer and Binary Cross Entropy as the loss function. For this model's discriminator it seems it is doing a regression task, the loss function is trying to minimize the distance between outputs and 1 (or 0). So I think the discriminator contributes nothing to the final performance. minimizing L1 loss between clean speech and generated speech make the whole system work.

So I discarded the discriminator and only train the generator for speech enhancement, it gives a very close performance of SEGAN. If only use the generator for training, the model could be seen as a de-noising auto encoder.

3.I'm kind of confused about that how much does the discriminator contribute to the final performance during the Adversarial Process. Because for speech enhancement task, we are not 'generate' basically but 'mapping' noisy signal to clean signal.

Many thanks!

@JUiscoming
Copy link

I think gan loss contributes high-frequency band. without gan loss, mse loss or l1 loss don't catch enough high-freq information due to low-power of the high-freq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants