Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request: Move @types/ssh2 devDependency to regular dependency #85

Open
cinderblock opened this issue Mar 21, 2023 · 0 comments
Open

Comments

@cinderblock
Copy link

Since this package publishes TypeScript types directly and doesn't rely on DefinitelyTyped, I think the dependency on @types/ssh2 should be a normal dependency. I think it's slightly confusing that half of the types don't work after installing ssh2-promise.

If this change were implemented, it would be slightly easier to use out of the box. Granted, the normal "fix" is to simply install @types/ssh2 as well. This has the added benefit that one could chose to not export the types to really minify package sizes, but that seems rare in this case.

Would this be considered? Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant