Issues/34: More compact array/map representation #43
Conversation
This is because slices are now compacted and as such are not easier on the eyes when looking at testdata/primitives.dump
komuw
changed the title
There was a problem hiding this comment.
My concern here is wrapping. If you have a slice or map of a certain number of elements, they are going to all be on the same line.
I looked at implementing a compact mode for slices/maps at one point, but ran into the problem that you need to handle wrapping and indentation everywhere, and I didn't bother finishing it. Ideally, indentation and wrapping should be handled at the writer level.
| case reflect.Bool, reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64, reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr, reflect.Float32, reflect.Float64, reflect.String: | ||
| // Where the elements in a slice/array are primitive types; dump in a compact manner | ||
| original := s.config.Compact | ||
| s.config.Compact = true |
There was a problem hiding this comment.
We should never mutate the configuration, which might be shared across multiple concurrent goroutines, and might be a constant at the caller's end. Let's add the flag to dumpState directly.
|
I have given this a little more thought. I think the work needed here is a little more than I had imagined.
|
|
Thank you! I might revisit this at some point. It's annoying, I agree. |
What:
Why: