Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize dissipation rate specification #22

Open
michael-a-hansen opened this issue Sep 13, 2022 · 0 comments
Open

Generalize dissipation rate specification #22

michael-a-hansen opened this issue Sep 13, 2022 · 0 comments

Comments

@michael-a-hansen
Copy link
Collaborator

Currently we're pretty stuck on Peters or constant dissipation. While a user can specify their own dissipation rate, it is up to them to parameterize it. Seems like we should invert some of our design so that "Peters" is just another function for the dissipation rate, which Spitfire manages in general. Ideally someone could provide a function for the dissipation rate and let Spitfire scale it accordingly for a desired stoichiometric or maximum dissipation rate.

We could also consider supporting a general function, say chi(z, user_param1, user_param2, ...) for which we defer evaluation until the additional parameters are provided through a tabulation interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant