Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve library builders for unstructured approaches #21

Open
michael-a-hansen opened this issue Sep 13, 2022 · 0 comments
Open

Improve library builders for unstructured approaches #21

michael-a-hansen opened this issue Sep 13, 2022 · 0 comments

Comments

@michael-a-hansen
Copy link
Collaborator

Currently the build_adiabatic_slfm_library method is used on its own as a standalone user-facing method, as well as internally by the nonadiabatic SLFM build_*_library methods. This is good reuse of code and if we were only ever interested in generating structured libraries it is fine. To enable code reuse for structured and unstructured library generation, we should rework this. Right now it builds a dictionary for the internal use and a Library for user-facing use. Is the dictionary the cleanest way to approach the unstructured case? It is based on the stoichiometric dissipation rate, which itself is meant for structuring and is not the most general thing we could do. A more general option would be to produce a totally flattened library with mixture fraction and the actual dissipation rate. Ideally we could then have a capability that takes such a library and some structuring rule (here, chi_st) to produce the structured (tensor product) 2D format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant