Incorrect route segment and turn configurations

[cwienands1]

Describe the issue
While configuring a route, I discovered two problems with the existing route segment and turn configurations.

Fyi, this is (so far) only a builder issue, not a runner issue. I wasn't able to remove the label.

Application details:

• Road Captain version: 0.7.0.7

Additional info
Issue 1

• Reproduce: Route from beach, up the Zwift KOM, which is Zwift KOM 1, turn right onto Zwift KOM Bypass, then attempt to turn left onto Zwift KOM 2.
• Symptom: The endpoint of the Zwift KOM 2 segment is shown to be at the "Western" intersection with the bypass, where the route is coming from, not on the "Eastern" end. Essentially, the segment is showing the wrong direction on the map.
• Further analysis: I looked at the route json and noticed that the direction for the "Zwift KOM 2" segment is set to unknown, which is probably why the direction shows up incorrectly in the UI. My guess is this: The segments Zwift KOM Bypass and Zwift KOM 2 touch on both ends. The turns-watopia.json file doesn't contain information about whether a turn connects to points A or B of a segment, so in this specific case the routing logic doesn't know which end of Zwift KOM 2 to connect to, and in which direction the segment should be ridden. If my guess is correct, a simple fix might be to split the Zwift KOM 2 into two segments so that the direction is always unambiguous to the routing logic. I also took a quick look over the map, and I think this is probably the only occurrence where two segments touch each other on both ends.

roadcaptain-route-test1.json

Edited by @sandermvanvliet:

Issue 2

See #127

[cwienands1]

Just found another routing problem, a missing turn:
Segment Bridge sprint to beach road (watopia-bambino-fondo-001-after-after-after-after-before-after is missing a left turn at its Southern end onto that newish shortcut segment Italian villas loop 3 (watopia-beach-island-loop-004).

RoadCaptain/src/RoadCaptain.Adapters/turns-watopia.json

Line 104 in a80ab43

"goStraight": "watopia-bambino-fondo-001-after-after-after-after-before-before"

[sandermvanvliet]

I've reproduced issue 1 and the funny thing is that the end points of those two segments are just far enough apart for the algo to discard it 🤷

[sandermvanvliet]

Issue 1 is fixed:

[cwienands1]

Great!