Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warning of Biobank.contact.purpose RESEARCH #84

Open
alexanderkiel opened this issue May 3, 2020 · 3 comments
Open

Fix Warning of Biobank.contact.purpose RESEARCH #84

alexanderkiel opened this issue May 3, 2020 · 3 comments
Assignees

Comments

@alexanderkiel
Copy link
Member

For the value RESEARCH in purpose coding, we introduced our own code system https://fhir.bbmri.de/CodeSystem/ContactType. But somehow the validator doesn't like it, because the usual code system at this point is http://hl7.org/fhir/ValueSet/contactentity-type. The warning is:

Warning @ Organization.contact[1].purpose (line 111, col20) : 
  None of the codes provided are in the value set http://hl7.org/fhir/ValueSet/contactentity-type
  (http://hl7.org/fhir/ValueSet/contactentity-type), and a code should come from this value set
  unless it has no suitable code) 
  (codes = https://fhir.bbmri.de/CodeSystem/ContactType#RESEARCH)
@noemide
Copy link
Contributor

noemide commented May 8, 2020

Maybe we could supress this error somehow? The binding is extensible and the original ValueSet does not include a fitting code, so unsing our own code is vaild here.

@alexanderkiel
Copy link
Member Author

I'm not sure if we have to somehow extend the binding explicitly. I only see that you defined the fix values of https://fhir.bbmri.de/CodeSystem/ContactType and RESEARCH in that slice. Btw. I would rename the slice from contact to research.

@noemide
Copy link
Contributor

noemide commented Dec 17, 2020

Making a binding wider in a derived profile is not possible. I'll see if we can supress the waring. If not, i will add a comment to the validation support page that warnings like this are to be expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants