Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC naming issue[Forge / Fabric] #77

Open
2 tasks done
Flemmli97 opened this issue Jan 26, 2022 · 4 comments
Open
2 tasks done

NPC naming issue[Forge / Fabric] #77

Flemmli97 opened this issue Jan 26, 2022 · 4 comments

Comments

@Flemmli97
Copy link

Flemmli97 commented Jan 26, 2022

Describe the bug
When you rename a npc thats a player to someone online it can disconnect them and prevent them from logging on again till that npc is removed.
I am unsure how to reliably reproduce this as it doesnt happen everytime you do it.

Platform(s)

  • Fabric

Environment(s)

  • Server

Versions

  • Minecraft 1.18.1
  • Taterzens 1.8.1
  • DisguiseLib: 1.1.2

To Reproduce
Steps to reproduce the behavior:

  1. Launch server '...'
  2. Spawn npc
  3. Rename npc to someone online

Logs

https://gist.github.com/Flemmli97/302e27e2238453b25f6abdc8596015b6

Additional context

Using this scarpet script to rename npcs:

https://gist.github.com/Flemmli97/dfb5d50115a083a50049617797d4a536

while it only runs the /npc command internally it might have something to do with this too.

@samolego
Copy link
Owner

Ough that's bad, thanks for report. You could try adding a space after the name until this is fixed.

@samolego samolego reopened this Jan 26, 2022
@samolego
Copy link
Owner

wrong button 😅

@Flemmli97 Flemmli97 changed the title Bug report [Forge / Fabric] NPC naming issue[Forge / Fabric] Jan 26, 2022
@Flemmli97
Copy link
Author

note: /npc create which spawns an npc named after you doesnt seem to cause this problem

@samolego
Copy link
Owner

samolego commented Jan 26, 2022

Ah, yes, thanks for pointing out.
Seems like it could be caused by stackoverflow ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants