Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolved is not recursive #181

Open
samdenty opened this issue Apr 7, 2021 · 1 comment
Open

resolved is not recursive #181

samdenty opened this issue Apr 7, 2021 · 1 comment
Assignees
@samdenty
Labels
bug Something isn't working

Comments

@samdenty
Copy link
Owner

samdenty commented Apr 7, 2021 •
edited

in v2 this is breaking, https://github.com/gqless/gqless/blob/7e084fb2f06f47f4f4c0a3e77e2ad2d1da902399/packages/gqless/src/Client/resolvers.ts#L450 this should do another call to resolved(dataFn)
@PabloSzx
Copy link
Contributor

PabloSzx commented Apr 7, 2021 •
edited

there is some logic needed for this to be made, which is disable the recursion with subscriptions and disabling refetch if set to true for the second+ passes.

@samdenty samdenty added the bug Something isn't working label Apr 8, 2021
@samdenty samdenty self-assigned this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdenty samdenty

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PabloSzx @samdenty