Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic SinkCollector for sinks #51

Open
sam-goodwin opened this issue Sep 3, 2019 · 0 comments
Open

generic SinkCollector for sinks #51

sam-goodwin opened this issue Sep 3, 2019 · 0 comments
Labels

Comments

@sam-goodwin
Copy link
Owner

sam-goodwin commented Sep 3, 2019

Found a bug in Collectors (#50). All collectors redundantly copied a bug where the Promise was not awaited.

this.sender = props.stream.forBatch(this.resource, 'ToStream', {
depends: this.writeAccess(),
handle: async (events, self) => {
self.sink(events);
}
}) as any;

Bug is fixed, but we should make a generic SinkCollector for all types that implement Sink<T>.

@sam-goodwin sam-goodwin changed the title generic collector for sinks generic SinkCollector for sinks Sep 3, 2019
@sam-goodwin sam-goodwin added the good first issue Good for newcomers label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant