Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Transactions should be able to run inline in handlers #448

Open
thantos opened this issue Sep 17, 2023 · 4 comments
Open

Feat: Transactions should be able to run inline in handlers #448

thantos opened this issue Sep 17, 2023 · 4 comments

Comments

@thantos
Copy link
Contributor

thantos commented Sep 17, 2023

No description provided.

@sam-goodwin
Copy link
Owner

100%. Also, no need for them to be lambdas.

@sam-goodwin
Copy link
Owner

We need to make a decision: will transactions still be allowed to called directly over the API gateway? If so, we need to support middleware and zod schemas for auth and validation

@thantos
Copy link
Contributor Author

thantos commented Sep 25, 2023

I think it's be better if allow transactions to be run inline in non workflow handlers. Then wrap it in a command. Maybe add command.transaction

@sam-goodwin
Copy link
Owner

I agree! I think they should be entirely internal. They don't need to be named, schema'ed or anything. Just a utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants