Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing in just an id #97

Closed
lholmquist opened this issue Jul 7, 2020 · 0 comments · Fixed by #98
Closed

Deprecate passing in just an id #97

lholmquist opened this issue Jul 7, 2020 · 0 comments · Fixed by #98
Labels
Good First Issue Road To 1.0.0

Comments

@lholmquist
Copy link
Contributor

I would like to deprecate passing just an id like client.getPerson(1) and switch to using just an object like client.getPerson({id: 1})

This would be a breaking change, but we could do the deprecation message first.

However, this library is not at 1.x yet, so breaking changes could be expected, but having a deprecation message would be nice and will be removed once it hits 1.0.0
lholmquist added a commit to lholmquist/swapi-node that referenced this issue Jul 7, 2020
@lholmquist
feat: Add deprecation notice for passing just an ID in.
c12b786 
fixes salty-pig#97
@lholmquist lholmquist mentioned this issue Jul 7, 2020
Merged
lholmquist added a commit that referenced this issue Jul 7, 2020
@lholmquist
feat: Add deprecation notice for passing just an ID in. (#98)
87dba0a 
* feat: Add deprecation notice for passing just an ID in.

fixes #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Road To 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add deprecation notice for passing just an ID in. lholmquist/swapi-node
1 participant
@lholmquist