Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change #16

Closed
lholmquist opened this issue Mar 3, 2017 · 2 comments · Fixed by #100
Closed

API change #16

lholmquist opened this issue Mar 3, 2017 · 2 comments · Fixed by #100
Labels
enhancement Good First Issue help wanted Road To 1.0.0

Comments

@lholmquist
Copy link
Contributor

lholmquist commented Mar 3, 2017 •
edited

i would like to change the API and get rid of the get part of the name.

so getFilm would become film

This would be a breaking change and would need a major version release
@lholmquist
Copy link
Contributor Author

Also i think the paging method names could just be previous and next instead of previousPage and nextPage

@lholmquist
Copy link
Contributor Author

Since this is breaking, we can add a deprecation notice first. This would see the library keeping both methods(get and non-get) and then in 1.0.0 we can remove the deprecated methods

lholmquist added a commit to lholmquist/swapi-node that referenced this issue Jul 8, 2020
@lholmquist
feat: Add new simplier get methods. Deprecate the old ones.
d00415a 
fixes salty-pig#16
@lholmquist lholmquist mentioned this issue Jul 8, 2020
Merged
lholmquist added a commit that referenced this issue Jul 9, 2020
@lholmquist
feat: Add new simplier get methods. Deprecate the old ones. (#100)
b29d1a4 
fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Good First Issue help wanted Road To 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add new simplier get methods. Deprecate the old ones. lholmquist/swapi-node
1 participant
@lholmquist