Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

previousPage and nextPage return a 404 #103

Closed
lholmquist opened this issue Jul 10, 2020 · 0 comments · Fixed by #104
Closed

previousPage and nextPage return a 404 #103

lholmquist opened this issue Jul 10, 2020 · 0 comments · Fixed by #104
Labels
bug

Comments

@lholmquist
Copy link
Contributor

There is a bug with how the paging works. Since the base url is using https and the link that is returned for next/previous is using http, the code makes the request is getting confused.
@lholmquist lholmquist added the bug label Jul 10, 2020
lholmquist added a commit to lholmquist/swapi-node that referenced this issue Jul 10, 2020
@lholmquist
fix: better parse of the baseURL
55d7aba 
fixes salty-pig#103
@lholmquist lholmquist mentioned this issue Jul 10, 2020
Merged
lholmquist added a commit that referenced this issue Jul 10, 2020
@lholmquist
fix: better parse of the baseURL (#104)
6c25d0c 
* This fixes the bug that was happening when using the nextPage and previousPage helpers

fixes #103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: better parse of the baseURL lholmquist/swapi-node
1 participant
@lholmquist