Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository management #79

Open
hatifnatt opened this issue Mar 28, 2018 · 0 comments
Open

Repository management #79

hatifnatt opened this issue Mar 28, 2018 · 0 comments

Comments

@hatifnatt
Copy link
Collaborator

  1. Why Debian repository key stored locally in formula repository? While RedHat keys fetched directly via http.
  2. What need in multiple repo states why it can't be single state? And all other tricks like including state file as Jinja template and then using extend to declare requisites.
  3. Why result of applying repo state is actually installed packages? I think it must only configure repository and it's all. Installation must be preformed in conf state, or may be even better in separate install state.

My thoughts on this:

  • Repository state can be simplified, local file with gpg-key can be removed, if you can fetch packages from official repository, you also can fetch gpg-key from it. If you are using your own or 3-rd party repository, you don't need this key at all.
  • Multiple zabbix.*.repo states can be simplified to single zabbix.repo old ones can be saved for compatibility. Extend can be done in installation state.
  • I think there is need to be single repo state, if you wan't use official repo - include it in top file, or run via state.sls. Another approach also can be used control usage of official repo via pillar, like in php-formula may be it's even better to control everything via pillar.
  • repo must not install anything except repository itself, package installation must be moved in conf or even better in separate install state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant