Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated module.run #102

Open
OrangeDog opened this issue Jan 10, 2019 · 4 comments
Open

Deprecated module.run #102

OrangeDog opened this issue Jan 10, 2019 · 4 comments

Comments

@OrangeDog
Copy link

[WARNING ] The function "module.run" is using its deprecated version and will expire in version "Sodium".
hatifnatt added a commit to hatifnatt/zabbix-formula-community that referenced this issue Oct 12, 2020
@hatifnatt
fix(zabbix agent): workaround module.run syntax change
b93b3b4 
Fix: saltstack-formulas#102
hatifnatt added a commit to hatifnatt/zabbix-formula-community that referenced this issue Oct 12, 2020
@hatifnatt
fix(zabbix agent): workaround module.run syntax change
a68d847 
Looks like deprecation of legacy module.run syntax is postponed until Salt v3005
https://docs.saltstack.com/en/latest/ref/states/all/salt.states.module.html#salt.states.module.run

Fix: saltstack-formulas#102
@hatifnatt
Copy link
Collaborator

I don't think that it is possible to get rid of deprecation warning until

use_superseded:
  - module.run

present in the minion configuration.
But it's possible to preserve formula functionality if

use_superseded:
  - module.run

present and after upgrade to Salt >= v3005
What do you think about this solution master...hatifnatt:workaround_module_run_deprecation

@OrangeDog
Copy link
Author

Apparently it's not deprecated any more: saltstack/salt#58705

@hatifnatt
Copy link
Collaborator

Do you think workaround I provided is still necessary or, due new information there is no reason to complicate this formula?

@OrangeDog OrangeDog mentioned this issue Jul 20, 2022
Merged
@OrangeDog
Copy link
Author

There's also a module.watch state that errors if Salt is using the new syntax.

All these problems should go away when saltstack/salt#61772 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrangeDog @hatifnatt