Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks and vscode specific features #1

Open
cometeer opened this issue Feb 16, 2017 · 5 comments
Open

Tweaks and vscode specific features #1

cometeer opened this issue Feb 16, 2017 · 5 comments

Comments

@cometeer
Copy link

Hello @sallar,

I've made some small tweaks for a personal version of the theme. (mostly the UNO5 was just to close to the background color for my liking) but i've also added some properties for handling the multi select features the way viscose works with them (I have no clue how text mate works with this as i've never used that)

Are you at all interested in contributions that deviate from the original theme (possibly as alternate version in the same package) or would you prefer I changed the name and make this a new package on the marketplace?

@sallar
Copy link
Owner

sallar commented Feb 16, 2017

Hi @cometeer,

I'd appreciate the changes. Yes we can put that in the same package if you wouldn't mind. Send a PR and I will merge it. Also if there's vscode-specific changes that you can make to theme.xml file to make it better, that would be welcome too :)

@sallar
Copy link
Owner

sallar commented Mar 9, 2017

Hi @cometeer, I missed your PR 😱 Really sorry. Will check it out ASAP.

@cometeer
Copy link
Author

Sure thing, i've got my version as seen in the PR running locally so no rush :)

@sallar
Copy link
Owner

sallar commented Mar 13, 2017

@cometeer It would be nice if we could make screenshots of the new changes... but even if we don't i think it's still fine. Or maybe a better name than "Alt"?

@cometeer
Copy link
Author

Agreed on the name, though im not really inspired atm for something else.

Im thinking about doing another round of tweaks this weekend maybe, ill see if i can generate pictures after im done with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants