Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid GitHub API failures (Release Notes) #483

Open
pgorod opened this issue Oct 27, 2020 · 3 comments
Open

Avoid GitHub API failures (Release Notes) #483

pgorod opened this issue Oct 27, 2020 · 3 comments

Comments

@pgorod
Copy link
Contributor

pgorod commented Oct 27, 2020

Page with Issue

Our Release Notes pages use the GItHub API to fetch members' avatars. Currently, API failures might cause problems when building the site. And API failures are not that uncomon - not full GitHub outages, but a much simpler thing: exhausting API limits due to too many requests when building the site.

Underlying issue

This is related to a Hugo known issue, gohugoio/hugo#6954

After a long time stalled, recently there was a fix for this, check it out.

What needs to be done here on SuiteDocs

  • wait for the fix to be released and work to upgrade our Hugo to that release
  • understand how it works and adjust our API code to fail gracefully (build the site without interruption, but use a placeholder image if it can't download the avatar).

This is the file that needs to get the improved error handling:

https://github.com/salesagility/SuiteDocs/blob/master/layouts/shortcodes/ghcontributors.html

@samus-aran
Copy link
Contributor

Yup! This is what I now face.... Either jump ahead and provide the fall back now and work on the upgrade. I'm not sure if they can be done separately but an upgrade is always good.

@serhiisamko091184
Copy link
Contributor

Hello @pgorod,

I'd like to check if this issue is still valid?

Thanks in advance!

Regards,
Serhii

@pgorod
Copy link
Contributor Author

pgorod commented Mar 20, 2024

I guess it is. In general, the whole Docs stack should get some love (and upgrades). That would be Hugo, the Learn theme, asciidoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants