Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about Page admin/suitecrm-analytics/SCRM-Data-Integration.adoc #462

Open
dbortnic opened this issue Jun 26, 2020 · 0 comments
Open

Comments

@dbortnic
Copy link

Page with Issue

https://docs.suitecrm.com/admin/suitecrm-analytics/scrm-data-integration/

What is wrong, less clear, or missing

Environment: Centos 7

Hello.
So i followed this article to install Data Integration.
At the step https://docs.suitecrm.com/admin/suitecrm-analytics/scrm-data-integration/#_installing_suitecrm_data_integration
...when the user is told to execute the script "/setup-suitecrm-data-integration.sh"
...the script exits full of syntax errors

The script starts with "#/bin/sh" which is not even a valid "shebang" (should be #!/bin/sh or #!/bin/bash....as far as i know)
Then, there is the "while" at line 24 which make no sense to me:

        file="./install.properties"

        if [ -f "$file" ]
        then

                while IFS='=' read -r key value
                do
                        key=$(echo "$key" | tr '.' '_')
                        eval '${key}'='${value}'

                done < "$file"

The "eval" command takes its arguments and executes them as a command, so it is expect that the script will exit with errors like

./setup-suitecrm-data-integration.sh: line 27: #: command not found
./setup-suitecrm-data-integration.sh: line 27: SUITECRM_ANALYTICS_WEBAPP_PORT=8080: command not found
./setup-suitecrm-data-integration.sh: line 27: =: command not found
./setup-suitecrm-data-integration.sh: line 27: #: command not found
./setup-suitecrm-data-integration.sh: line 27: SMTP_ENABLED=1: command not found
./setup-suitecrm-data-integration.sh: line 27: #: command not found

$file contains just "key=value" pairs and a few comments and "eval" tries to execute them.

...I would rather assume that i`m missing something and the script is above my understanding than that this "Documentation" is absolutely broken.
Please advice, what am i doing wrong ?

Proposed fixes and/or additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant