Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Entered and Date Modified list view filters not working #10395

Open
maclordaj opened this issue Apr 8, 2024 · 0 comments
Open

Date Entered and Date Modified list view filters not working #10395

maclordaj opened this issue Apr 8, 2024 · 0 comments
Labels
Area:Search Issues & PRs related to all things regarding Search Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Major Significant impact/severe disruption Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Bugs within the core SuiteCRM codebase

Comments

@maclordaj
Copy link

Issue

I applied the current 7.14.3 update and have also tested on a new installation.
Since at least this update when we set a list search filter (either advanced or basic) using the Date Entered or Date Modified fields, the results won't be correct.
I've pinpointed the cause to a code change in the ./include/SearchForm/SearchForm2.php file related to this commit:
serhiisamko091184@a24b68d

If we comment that line again the filters work as expected.

Expected Behavior

When using a date entered or modified filter, the results should be filtered by that date. e.g. I use the calendar to choose yesterday's (or tomorrow's) date for the date created field, so it shouldn't show records created today.

Actual Behavior

Today's records are shown.

Possible Fix

Deleting the line from this commit fixes that issue, but indeed the underlying issue that the commit was trying to fix won't work again.
The commit doesn't explain why to fix one module this line is added without affecting other modules.
Although I believe it has more to do with the way the date is changed between choosing it in the calendar and how the data in the backend is processed.
I added a custom date field (without range) and it seems to work.
It remains unknown to me if this affects custom date filters with range enabled.
Filtering using the included expected closing date for the opportunity field seems to also work in a new install.

Steps to Reproduce

  1. Use the studio to add the date filters to the filter views (basic and/or advanced) in the opportunities module. Save your changes.
  2. Load the Opportunities list view.
  3. Try to filter the list view by the “Date Entered”, or “Date Modified” field.

Context

Since I was able to reproduce using a new install and this is a default and very common field to use, I believe it might be a high priority bug. I have commented the line directly on the core file for now as a tentative workaround.

Your Environment

  • SuiteCRM Version used: 7.14.3
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Safari
  • Environment name and version (e.g. MySQL, PHP 7):
  • Operating System and version (e.g Ubuntu 16.04): Debian
@johnM2401 johnM2401 added Type: Bug Bugs within the core SuiteCRM codebase Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Area:Search Issues & PRs related to all things regarding Search Severity: Major Significant impact/severe disruption labels Apr 9, 2024
@gemartin21 gemartin21 added the Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Search Issues & PRs related to all things regarding Search Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Severity: Major Significant impact/severe disruption Status: Team Investigating Labels for issues in which the Core Team are investigating / Intend to Investigate Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

3 participants