Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10353 - Fatal error in AOR Reports dashlet #10354

Closed
wants to merge 1 commit into from
Closed

Fix #10353 - Fatal error in AOR Reports dashlet #10354

wants to merge 1 commit into from

Conversation

fluffyballs
Copy link

Description

Fix #10353

Motivation and Context

Fixes fatal error.

How To Test This

Repeat procedure defined in issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Feb 6, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184
Copy link
Contributor

Hey @fluffyballs,

thanks for your contribution,

I'd like to draw your attention to the commit:

image

would you be so kind to update your commit message to the following format below:

image

More useful information on how to contribute is available here:
https://docs.suitecrm.com/community/contributing-code/bugs/

Many thanks in advance!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Feb 8, 2024
@chris001
Copy link
Contributor

chris001 commented Feb 8, 2024

Yes, @fluffyballs in your commit message, you only need to add the missing # next to the 10353, making it #10353

@fluffyballs
Copy link
Author

Sorry, typo when writing the message. It should be updated now.

@serhiisamko091184
Copy link
Contributor

Hi @fluffyballs,

thanks a lot for the quick response and update!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Dashlets Issues & PRs related to all things regarding the dashlets Branch:Hotfix PR 4-8 Score given to PRs once assessed and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Feb 9, 2024
@serhiisamko091184 serhiisamko091184 mentioned this pull request Apr 23, 2024
Merged
6 tasks
@jack7anderson7
Copy link
Contributor

Hi @fluffyballs,

Thank you for your contribution and the time you took to create the PR

We have ultimately chosen to go with another PR that resolves this issue: #10411 , so we will close this PR.

However we are still grateful for your time and contribution.

Thank you again
Jack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Dashlets Issues & PRs related to all things regarding the dashlets Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error in AOR Reports dashlet
5 participants
@fluffyballs @SuiteBot @serhiisamko091184 @chris001 @jack7anderson7