Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable for default channel #1060

Open
3 tasks
timuric opened this issue Dec 20, 2023 · 2 comments
Open
3 tasks

Add env variable for default channel #1060

timuric opened this issue Dec 20, 2023 · 2 comments

Comments

@timuric
Copy link
Member

timuric commented Dec 20, 2023

Since storefronts can be used with different datasets, the default channel slug should be configurable via .env

  • Add variable to .env.examples
  • Use variable across the codebase
  • Default slug should be aligned with the most common Saleor dataset
@bertoldoklinger
Copy link

Hi there! this will affect the url path? whats your point of view on this? we could change the path from '/default-channel' to '/' via .env?

@timuric
Copy link
Member Author

timuric commented Jan 14, 2024

Hi there! this will affect the url path? whats your point of view on this? we could change the path from '/default-channel' to '/' via .env?

I think channel information should not belong in url in most use cases, instead it should be mapped to a locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants