Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base price fields in Checkout and Order should contain only catalogue promotion discount #15334

Open
korycins opened this issue Jan 30, 2024 · 0 comments

Comments

@korycins
Copy link
Member

korycins commented Jan 30, 2024

Problem

Checkout and Order models have fields base_x_price. The fields store the values that we use to calculate the discount based on the catalog promotions. Some vouchers like specific_products are also included in base_x_price fields which causes misleading in the assumption that base price always contains only catalog promotion.
The idea here is to exclude the applying vouchers from base_x_price fields and move them to CheckoutLineDiscount and OrderLineDiscount. Thanks to it, the base_x field will always store the value of the product without any order discounts or voucher applied to a specific line.
The discount from OrderLineDiscount/CheckoutLineDiscount should be applied to price field.
The tax payload that we send to tax app should have included voucher/discount for specific-line
The avatax plugin should also include the voucher/discount for specific-line


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant