Assigning attribute as variant attributes triggers overriding variant name

[KarolJagodzinski]

What are you trying to achieve?

Assigning attributes shouldn't have any impact on variant name

Steps to reproduce the problem

1. Create a product with variants.
2. There are two cases: Create a variant with SKU, and a variant without SKU
3. Assign an attribute to product type as a variant attribute
4. You will notice that variant name without SKU is changed to Saleor ID, and a variant name with SKU is changed to SKU

What did you expect to happen?

There shouldn't be any impact on variant name

Logs

No response

Environment

Saleor version: dashboard v3.18.2, core v3.18.12

[teddyondieki]

I was able to reproduce this bug and would like to help fix it @maarcingebala

[IKarbowiak]

Go on @teddyondieki 🚀. I assigned you to this issue

[teddyondieki]

@IKarbowiak I propose adding a checkbox on the ProductType page that would let users Overwrite Product Variant Names. What do you think about the approach? Can I go ahead? It would require frontend work too.

[IKarbowiak]

Hi @teddyondieki.
I think we should go with the most straightforward solution, and just not change the variant SKU if it's already set.

[teddyondieki]

@IKarbowiak I have a PR that addresses this issue. I would appreciate your review.