Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saleor CLI 1.32.0 does not complete steps listed in template #177

Open
PatricioNG opened this issue Jul 6, 2023 · 6 comments
Open

Saleor CLI 1.32.0 does not complete steps listed in template #177

PatricioNG opened this issue Jul 6, 2023 · 6 comments
Assignees

Comments

@PatricioNG
Copy link

In the app template repository it's listed that the steps that will be completed are:

In this step, Saleor CLI will:
- clone this repository to the specified folder
- install dependencies
- ask you whether you'd like to install the app in the selected Saleor environment
- create .env file
- start the app in development mode

Yet following these steps does not produce that result, attached is the console output. After running saleor app create test I am prompted for app information but no repository is cloned, and a .env is not created.
image

Environment:

  • Windows 11
  • Node v20.3.1
  • CLI installed via npm
  • Saleor CLI 1.32.0
@lkostrowski
Copy link
Member

@peelar can you please verify docs ?

@peelar
Copy link
Member

peelar commented Jul 10, 2023

Hello @PatricioNG 👋

I was able to reproduce it. I passed it to our @saleor/devtools team. I will keep you posted.

@PatricioNG
Copy link
Author

@peelar @lkostrowski Thanks both!

@zaiste
Copy link
Contributor

zaiste commented Jul 10, 2023

The command app create was recently updated to app template to maintain consistency. The former is now used to trigger the mutaton of creating an App. (cf. saleor/cli#645).

I've updated the docs in this repo #178 cc @peelar

@PatricioNG let me know if it works for you

@peelar peelar removed their assignment Jul 12, 2023
@PatricioNG
Copy link
Author

PatricioNG commented Jul 12, 2023

@zaiste yes it does work now to install the app, seems like there's additional differences between the docs here and the CLI however as all steps aren't documented.

After installing, step 5 - Start the app in development mode did not occur automatically, then after starting the app manually and running the saleor app tunnel command as indicated it throws an error:

image

@lkostrowski
Copy link
Member

@PatricioNG we will look into docs, meanwhile you can install ngrok to make it work:
https://ngrok.com/

You can use it directly (ngrok http 3000) or use CLI saleor app tunnel which wraps ngrok for you

You can also set up fully local development (no need for tunneling) - more here
https://docs.saleor.io/docs/3.x/developer/extending/apps/local-app-development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants