-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when caching is disabled by HTTP header Cache-Control
#50
Comments
More weirdness - the bonus point 5. is working fine when I remove the |
We are encountering the same crash in our app, however, we are not able to reproduce it. It happened to me once with url that worked before and after just fine, it seems quite random. We can also see quite a bit of such crashes in crashlytics, this is one of them:
You can check the image, it's a real url: https://d34-a.sdn.cz/d_34/c_img_gT_q/dMUUDV.jpeg?fl=res,2100,2000,1 We've been using version |
I'm having the same crash reporting on version
Crash report:
|
My server is returning images with these HTTP headers.
This causes crash when used in Telephoto with Coil. The crash does not happen when using only Coil.
In my app (can't share), using
me.saket.telephoto:zoomable-image-coil:0.5.0
, the image shows up for the first time, and the crash occurs when the screen is re-opened and Telephoto attempts to access is from the cache.In the
telephoto:sample
app, at the latest commit, it crashes right away.Reproduction steps
http://10.0.2.2:3000/my-fking-image
telephoto
project, apply these changes containg the URL and other stuff - patch filerespectCacheHeaders(false)
, the app no longer crashes, but it gets stuck in cycle, observe "Start" being printed over and over in the log, image never showing up.Expected: App works with "no-cache" HTTP headers, not attempting to save to cache, either memory or disk, and not crashing. Furthermore,
respectCacheHeaders(false)
should allow me to use cache, see.The text was updated successfully, but these errors were encountered: