Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow option to disable overscroll #17

Open
chrisbanes opened this issue Jul 18, 2023 · 3 comments
Open

Allow option to disable overscroll #17

chrisbanes opened this issue Jul 18, 2023 · 3 comments

Comments

@chrisbanes
Copy link

Currently the draggable state is set to overscroll with resistance when the scroll isn't allowed (here). This can easily interfere with any parent horizontal gestures. Add an option to disable this?
@saket
Copy link
Owner

saket commented Jul 18, 2023

Sounds good! Do you want to send a PR?

I'm also curious about your usecase. Can you share a video?

@chrisbanes
Copy link
Author

Sure. The use case is iOS gesture navigation: chrisbanes/tivi#1379

@chrisbanes chrisbanes mentioned this issue Jul 18, 2023
Merged
chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 18, 2023
@chrisbanes
Disable swipe's overscroll
9c2d8b3 
Related: saket/swipe#17
chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 18, 2023
@chrisbanes
Disable swipe's overscroll (#1406)
d2f9836 
Related: saket/swipe#17
@saket
Copy link
Owner

saket commented Sep 22, 2023

I was thinking more about this today. Shouldn't this be handled automatically by nested scroll? Horizontal gestures intended for the parent shouldn't reach your list items.

@saket saket mentioned this issue Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisbanes @saket