Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boxed booleans and getters #199

Open
robertlemmen opened this issue Apr 18, 2018 · 2 comments · May be fixed by #200
Open

boxed booleans and getters #199

robertlemmen opened this issue Apr 18, 2018 · 2 comments · May be fixed by #200

Comments

@robertlemmen
Copy link

boxed boolean properties where the accessor is of the "isProperty()" format, this can be worked around by adding a ugly "getProperty()" accessor.

I guess IntrospectionUtils::findReadMethodHandle() should include boxed booleans when switching the accessor pattern to look for...
robertlemmen pushed a commit to robertlemmen/catatumbo that referenced this issue Apr 18, 2018
treat boxed Boolean fields like primitive ones
39d3314 
this fixes sai-pullabhotla#199
robertlemmen pushed a commit to robertlemmen/catatumbo that referenced this issue Apr 18, 2018
treat boxed Boolean fields like primitive ones
586cbc7 
this fixes sai-pullabhotla#199
robertlemmen pushed a commit to robertlemmen/catatumbo that referenced this issue Apr 18, 2018
treat boxed Boolean fields like primitive ones
f2e5782 
sai-pullabhotla#199
@robertlemmen robertlemmen linked a pull request Apr 18, 2018 that will close this issue
Open
@sai-pullabhotla
Copy link
Owner

@robertlemmen -

Thanks for the PR.

This was intentional as boxed Booleans have a third state of NULL, in addition to the true/false. IDEs, tools like Lombok, also generate a getXXX method for boxed booleans.

If we need to start supporting isXXX for boxed boolean, it should be fully backward compatible. In other words, we first check for getXXX method, in the event that it is not present, then fall back to isXXX. This ensures we are backward compatible. Let me know your thoughts.

@Mistic92
Copy link

For me it's important to have 3 states in Boolean. Like yes/no/nodecision. So as @sai-pullabhotla sad, it should be backward compatible and not crash others code logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

treat boxed Boolean fields like primitive ones robertlemmen/catatumbo
3 participants
@Mistic92 @robertlemmen @sai-pullabhotla