Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the process for updating this repository? #39

Open
saraedum opened this issue Feb 7, 2023 · 5 comments
Open

What is the process for updating this repository? #39

saraedum opened this issue Feb 7, 2023 · 5 comments

Comments

@saraedum
Copy link
Member

saraedum commented Feb 7, 2023

Some things in this repository could be updated I think. There's also a bunch of pending pull requests. What's the process of merging things here? Should just anybody with permissions press the merge button? Or does @VivianePons review things?

@koffie
Copy link
Collaborator

koffie commented Feb 7, 2023

Good question. I think there is no process at the moment. I don't remember how, but somehow I ended up as admin (not maintainer) of this relatively inactive repository. And judging by the commit history it looks like not every even has gone though a pull request in the past, and some things have been directly pushed to master.
I think ideally master would be a protected branch and every pull request needs at least one review. And after that anybody can merge.

@koffie
Copy link
Collaborator

koffie commented Feb 7, 2023

However if you see no action on your PR for some time after asking a review from several people, then go ahead and merge it yourself.

@seblabbe
Copy link
Collaborator

I am fine with a process as for developing sagemath. Meaning stuff gets merged when a positive review was given.

I just took a look at the 5 pull request and all of them have conflicts.

@seblabbe
Copy link
Collaborator

I think the authors of PRs with conflicts will not come back here to fix the conflicts. Are there PRs with conflicts that answer important issues?

@mkoeppe
Copy link
Member

mkoeppe commented Nov 17, 2023

My suggestion would be to archive this repository and point to a small number of well-maintained packages that can serve as examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants