Travis check #25
Open
Travis check #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkoeppe do you have any comments? |
|
Looks OK to me (haven't tested). |
|
Any reason this hasn't been merged yet? |
|
I am currently at Sage Days 117. There was a demo earlier this week on how to share code and create a package where we used sage_sample. I am now taking a look at all the PR that have been here for years now... No discussion has never been made about who should merge PRs. The current PR has conflicts. I let the author or someone else fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23 . Although I didn't completely manage to eliminate merge conflicts caused by key decreption. The openssl command is still dependent on the repository. It would really be a lot of hassle to also remove that one. I also added a new environtment variable
TEST_TRAVISand added it to the test matrix. This is a test environment that skips the building and caching of sage. This is very useful if one wants to be able to quickly see how travis reacts to different configurations without waiting for sage to build.