Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardhat-ethers@2.1.1 causes failures in GuardManager tests #436

Open
nikola-matic opened this issue Aug 16, 2022 · 0 comments
Open

hardhat-ethers@2.1.1 causes failures in GuardManager tests #436

nikola-matic opened this issue Aug 16, 2022 · 0 comments

Comments

@nikola-matic
Copy link

This doesn't really fit as either a feature or a bug; rather, it's more of a heads up. Note that with the release of hardhat-ethers@2.1.1, a check was introduced in getContractAt(), which causes all test cases in test/core/GnosisSafe.GuardManager.spec.ts to fail, as they all use AddressZero as a parameter to the previously mentioned function.

Please keep the issue open as we use it as a reference on the Solidity compiler team when we disable some externals cases, so that we can keep track of it, and hopefully re-enable said tests (or remove other restrictions) when this is fixed.
farreldarian pushed a commit to farreldarian/safe-contracts that referenced this issue Jan 14, 2024
@DaniSomoza
fix(protocol-kit): fix standardizeSafeTransactionData for predictedSa…
fbcf100 
…fe flow (safe-global#436)

* fix(protocol-kit): fix standardizeSafeTransactionData for predictedSafe flow

* removed Boolean casting in predictedSafe check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikola-matic