Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better EIP 1559 support for oracle gas price #1059

Open
schmanu opened this issue Mar 4, 2024 · 0 comments
Open

Better EIP 1559 support for oracle gas price #1059

schmanu opened this issue Mar 4, 2024 · 0 comments

Comments

@schmanu
Copy link
Member

schmanu commented Mar 4, 2024

Is your feature request related to a problem? Please describe.
For EIP 1559 we need different values for gas price estimation:

  • maxFeePerGas OR baseFee
  • maxPriorityFeePerGas

This is currently poorly reflected by our oracle settings as we can only configure one Oracle parameter.

Provide references to the feature you are implementing that requires this change
Workaround for this in the web interface: safe-global/safe-wallet-web#3380

Describe the solution you'd like
We need to be able to configure multiple oracle parameters for 1559 networks. Sadly oracles can vary in which parameters they return. So ideally we invent a new 1559 oracle type which can have different fields:

  • uri (required)
  • baseFeeParameter
  • maxPriorityFeePerGasParameter
  • maxFeePerGasParameter

Any two of the paramter values would be required as the third value can be computed from any combinations

  • baseFeeParameter + maxPriorityFeePerGasParameter = maxFeePerGas
  • maxFeePerGasParameter - baseFeeParameter = maxPriorityFeePerGas
  • maxFeePerGasParameter - maxPriorityFeePerGasParameter = baseFeeParameter

Describe alternatives you've considered
None

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant