Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return DApp information if present in origin #784

Open
iamacook opened this issue Oct 24, 2023 · 2 comments
Open

Return DApp information if present in origin #784

iamacook opened this issue Oct 24, 2023 · 2 comments

Comments

@iamacook
Copy link
Member

Feature request

With the implementation of "native WalletConnect", the details of the connected DApp (name, icon, etc.) are available and could be sent as part of the transaction origin. We currently map this to Safe Apps.

The client currently sends the WalletConnect Safe App as the origin to show the icon in the transaction list:

image

The client could alternatively send the DApp details and we could return the origin "as is" if no Safe App is found. This would allow the client to display DApp icons in the transaction list instead.

Considerations

  • Should we instead add a different key, e.g. dappInfo, as this is technically not from a Safe App
  • Does this have any security implications?
@fmrsabino
Copy link
Collaborator

To give some additional context. This was mentioned here safe-global/safe-config-service#621.

The scope of this feature was relatively big because the interface would take into consideration external projects or reaching a format that would be both extensible and robust (community driven).

However the scope can be reduced if this is tackled mostly by the Safe Client Gateway. That is, the scope would not change on the Safe{Core} side and therefore the Safe Transaction Service but start as a proposal to be tackled on the Safe{Wallet} side before pushing this to be more of an "open" format.

@katspaugh
Copy link
Member

Good to know.
From the client-side we can provide the following info when making a tx:

  • app name
  • app URL or origin
  • app icons in different sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants