Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialisation and output DTOs #68

Open
1 task
hectorgomezv opened this issue Sep 2, 2022 · 2 comments
Open
1 task

Implement serialisation and output DTOs #68

hectorgomezv opened this issue Sep 2, 2022 · 2 comments
Labels
Blocked Issue is blocked by a different issue

Comments

@hectorgomezv
Copy link
Member

hectorgomezv commented Sep 2, 2022

Dependencies

  • Centralise schemas and data validation (TODO: link to issue)

Context here.

Summary
Currently, as shown in the context link, we have some inconsistencies between the current Client Gateway implementation responses and this new service ones. The idea here is, instead of doing ad hoc mapping in the services to the expected formats, having DTOs providing the expected payload format, and implement a serialisation layer which takes "service objects" and converts them to "presentation objects" to fulfil client's requirements.

Note
We could do some additional research here to see what's the best solution, but we're already using AJV to validate incoming payloads so we could use it for serialisation as well.

@hectorgomezv hectorgomezv added the Blocked Issue is blocked by a different issue label Nov 24, 2022
@hectorgomezv
Copy link
Member Author

Blocked by #69

@fmrsabino
Copy link
Collaborator

Blocked by #69

More importantly. Do we need/want this. Even if the issue #69 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issue is blocked by a different issue
Projects
None yet
Development

No branches or pull requests

2 participants