Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added scrollTo behaviour to bring the currently edited section into viewport [Do not merge] #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added scrollTo behaviour to bring the currently edited section into viewport [Do not merge] #143

wants to merge 2 commits into from

Conversation

sesubash
Copy link

@sesubash sesubash commented Jan 9, 2023 •
edited

Changes

Added scrollTo behaviour to bring the currently edited section into viewport

Fixes #86

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Jan 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
resume-builder ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 8:31AM (UTC)

@sadanandpai sadanandpai added the enhancement New feature or request label Jan 17, 2023
@sadanandpai sadanandpai added this to In progress in version 2 via automation Jan 17, 2023
@sadanandpai
Copy link
Owner

sadanandpai commented Jan 17, 2023 •
edited

@sesubash the deployment has failed. Please check

image

@sesubash
Copy link
Author

@sadanandpai resolved the issue.

@sesubash sesubash changed the title Added scrollTo behaviour to bring the currently edited section into viewport Added scrollTo behaviour to bring the currently edited section into viewport [Do not merge] Jan 18, 2023
@gopal1996 gopal1996 removed this from In progress in version 2 Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gopal1996 gopal1996 Awaiting requested review from gopal1996

@siva-kannan3 siva-kannan3 Awaiting requested review from siva-kannan3

@sadanandpai sadanandpai Awaiting requested review from sadanandpai

At least 1 approving review is required to merge this pull request.

Assignees

@sesubash sesubash

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Focus element while adding element
4 participants
@sesubash @sadanandpai @gopal1996 @siva-kannan3