-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons are not rendered #1039
Comments
Hey @aitormendez , Looks like the fonts and images are not fetching from the correct path. $lg-path-fonts: 'https://cdn.jsdelivr.net/npm/lightgallery@2.1.2/fonts';
$lg-path-images: 'https://cdn.jsdelivr.net/npm/lightgallery@2.1.2/images'; in https://github.com/aitormendez/test/blob/main/web/app/themes/sage/resources/styles/app.scss#L7 @import 'tailwindcss/base';
@import 'common/global';
@import 'tailwindcss/components';
@import 'tailwindcss/utilities';
$lg-path-fonts: 'https://cdn.jsdelivr.net/npm/lightgallery@2.1.2/fonts';
$lg-path-images: 'https://cdn.jsdelivr.net/npm/lightgallery@2.1.2/images';
@import "~lightgallery/scss/lightgallery-bundle.scss"; I'll investigate and get back you |
Based on the discussion, it looks like either you need to copy the lightGallery fonts and images folder to your project or use any plugins like https://github.com/bholloway/resolve-url-loader when you import scss from Please re-open if you think this needs to be managed from the library itself |
I'm not sure what the cause is, so I'll keep the issue closed. Just in case: Sage 10 already has Laravel mix, wich includes resolve-url-loader. https://github.com/JeffreyWay/laravel-mix/blob/master/package.json#L136 |
Maybe it's worth checking with the sage team as well |
Description
Icons of buttons (arrows, close, magnifying glass, etc) are not shown.
Steps to reproduce
JS:
https://github.com/aitormendez/test/blob/main/web/app/themes/sage/resources/scripts/app.js
CSS:
https://github.com/aitormendez/test/blob/main/web/app/themes/sage/resources/styles/app.scss#L7
@import "~lightgallery/scss/lightgallery-bundle.scss";
Test site:
http://test.e451.net/2021/06/06/hello-world/
Additional context
Sage 10 WordPress starter theme
The text was updated successfully, but these errors were encountered: