Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari Content Blockers crash if the blocker list is too large #3

Open
saagarjha opened this issue Sep 11, 2015 · 8 comments
Open

Safari Content Blockers crash if the blocker list is too large #3

saagarjha opened this issue Sep 11, 2015 · 8 comments

Comments

@saagarjha
Copy link
Owner

Seems to be a bug in the content blocker loader. Anyone not experiencing this problem?

@azinicus
Copy link

I think this is the same issue being experienced by similar project rocketshipapps/adblockfast#26

@saagarjha
Copy link
Owner Author

Yes it looks like it. I'm not sure if it's a bug with the CSS or SFContentBlockerManager, since all I get is a crash log.

@azinicus
Copy link

Although it seems from my brief testing that the .json from this project actually blocks things whereas the AdblockFast one does not currently initiate by iOS (that one is much larger btw)

@saagarjha
Copy link
Owner Author

This was the most complex one that seemed to work.

@oldestlivingboy
Copy link

Safari is meant to handle up to 50K rules, so your list is unlikely too big. In the case of Adblock Fast, I introduced a syntax error that Safari was failing silently on.

@saagarjha
Copy link
Owner Author

That might be it. I'll have to look into it.

@mcfedr
Copy link

mcfedr commented Sep 26, 2016

Interested where the number 50K comes from

@saagarjha
Copy link
Owner Author

I believe this number has been increased recently, actually. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants