Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROpenSci Review #112

Open
5 of 12 tasks
s3alfisc opened this issue Apr 17, 2023 · 0 comments
Open
5 of 12 tasks

ROpenSci Review #112

s3alfisc opened this issue Apr 17, 2023 · 0 comments

Comments

@s3alfisc
Copy link
Owner

s3alfisc commented Apr 17, 2023

From @meghapsimatrix review, I agree with all points.

  • The vignette could go over why it is important to run many bootstrap replications. And, what does many mean? Also, is there a point where the number of bootstraps is too excessive?
  • The vignette could also provide a high level overview of the algorithm that makes cluster wild bootstrapping run fast, especially in R. The fastness seems to be the core idea behind the package so some detail on that somewhere on the vignette might be good.
  • Under the The boottest() function section, the text says that you are creating a random dataset but the code shows that you are using the voters dataset.
  • The vignette could also go over when to use which weights. For example, if we have a small number of clusters, Rademacher weights may not be appropriate.

In general, I should consider adding more guidelines on when wild cluster bootstrapping is required, which one to use, etc.

I have started by adding a brief literature section.

  • Sort the function reference alphabetically.
  • Better explanation of the plot method. Consider adding the test inversion blog post as vignette.

Last:

@s3alfisc s3alfisc changed the title Vignette Improvements Vignette and Documentation Improvements Apr 17, 2023
@s3alfisc s3alfisc changed the title Vignette and Documentation Improvements ROpenSci Review Apr 29, 2023
@s3alfisc s3alfisc linked a pull request Apr 29, 2023 that will close this issue
@s3alfisc s3alfisc removed a link to a pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant