Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value changes not propagated to other clients #260

Open
ESherlockP32 opened this issue Oct 6, 2023 · 10 comments
Open

Value changes not propagated to other clients #260

ESherlockP32 opened this issue Oct 6, 2023 · 10 comments

Comments

@ESherlockP32
Copy link

Let me first thank you for your great library, I really love working with it.
My problem is a minor issue: when more than one devices are connected to my esp32 and e.g. a slider is changed on one device the changed slider position is not propagated automatically to the other devices. When the page is reloaded the new slider position is shown correctly. Is there a workaround?

Thanks in advance.

@iangray001
Copy link
Collaborator

This is supposed to work. Are you sure you are on the latest version of the software?

@ESherlockP32
Copy link
Author

It worked for me in a project i made about a year ago if I remember correctly.
I reinstalled ESPUI version 2.2.2 today and my arduino-esp32 version was latly updated to 2.0.14.

@MartinMueller2003
Copy link
Collaborator

I think I may know what is wrong.
@s00500 Is there a target max number of clients to be supported?

@ESherlockP32
Copy link
Author

I didn't set a max number of clients in my code. Is there a default one?

@MartinMueller2003
Copy link
Collaborator

No there is not. I am trying to find out if there is a reasonable number to support. The problem is that there is only a single flag indicating that a value has changed and that flag does not indicate which clients need to be updated so as soon as one client gets updated, then none of the rest will. Guess which client gets updated first?

@s00500
Copy link
Owner

s00500 commented Oct 14, 2023

I think I may know what is wrong. @s00500 Is there a target max number of clients to be supported?

Not really, at least there should not be limits in the code

@MartinMueller2003
Copy link
Collaborator

OK. I have a pull mechanism designed.

@s00500
Copy link
Owner

s00500 commented Nov 3, 2023

@MartinMueller2003 do you need more input here ?

@MartinMueller2003
Copy link
Collaborator

Nope. I have a version that mostly works. I am testing with fragmented controls and seeing an issue.

@MartinMueller2003
Copy link
Collaborator

Fixed in PR: Changes to support keeping multiple Browser Clients in sync #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants