Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup in Webscreen #240

Open
I-Harii opened this issue Jul 18, 2023 · 4 comments
Open

Popup in Webscreen #240

I-Harii opened this issue Jul 18, 2023 · 4 comments

Comments

@I-Harii
Copy link

I-Harii commented Jul 18, 2023

I loved the ESPUI works, i am requesting to add POPUP in Webserver for much more flexibility.

@iangray001
Copy link
Collaborator

This is a very vague request.

If you are referring to integrating some Javascript pop-up library, the issue is that the more Javascript we bundle into it, the more space is taken away from what people actually want to do with the library. Adding a few dozen kB of Javascript hurts everyone who wants to use the library, we can just keep adding things.

You can add additional Javascript libraries yourself by putting them in the data/js folder, linking them in data/index.html rerunning tools/prepare_static_ui_sources.py, and including the generated header files into src/ESPUI.cpp and adding a server handler by copying an existing one. It would be good for someone to build a custom build system that allows arbitrary file inclusions but it has not been done yet.

@s00500
Copy link
Owner

s00500 commented Jul 19, 2023

so.... an actually very simple thing to do here would be adding an event to fire an alert to connected clients.... could be using the very basic window.alert function....

@iangray001
Copy link
Collaborator

Hmm, yes I suppose that could work, although I have no idea how effective window.alert() is on disparate clients.

@d-a-v
Copy link
Contributor

d-a-v commented Oct 12, 2023

It would be indeed useful to warn client on some hardware or internal software failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants