Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onion Services v3 support #157

Open
cypherbits opened this issue Aug 8, 2018 · 5 comments
Open

Onion Services v3 support #157

cypherbits opened this issue Aug 8, 2018 · 5 comments

Comments

@cypherbits
Copy link

v3 Hidden Services cannot be scanned.

@lorenzoromani1983
Copy link

lorenzoromani1983 commented Mar 27, 2019

You have to add the following lines in utils/validation:

if len(identifier) >= 62 && strings.HasSuffix(identifier, ".onion") {
	matched, _ := regexp.MatchString(`(^|\.)[a-z2-7]{56}\.onion$`, identifier)

this will not trigger the unrecognised onion error.

After editing the file, repete the install procedure and you will be ok with v3 addresses.

this worked for me.

@cypherbits
Copy link
Author

@lorenzoromani1983 yes yes, I already did that in my fork and even added and changed many other things. But I opened the issue here so it can get officially fixed sometime.

@brg123
Copy link

brg123 commented Dec 4, 2019

I tried just to copy it, but i dont know where it has to be placed. Could anyone show the full validation.go file source?
After editing i did go install github.com/s-rah/onionscan or was something meant with repeate the install procedere?

Thanks a lot

@q2dg
Copy link

q2dg commented Apr 8, 2021

Well, it seems this project is abandoned.
Sad

@nicomitor
Copy link

Well in fact the fix is quite easy ;-)
You have to add the following lines in utils/validation:

if len(identifier) >= 62 && strings.HasSuffix(identifier, ".onion") {
matched, _ := regexp.MatchString((^|\.)[a-z2-7]{56}\.onion$, identifier) <<<replace 16 in the original file with 56, which is the number of characters of a v3 hostname. That's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants